Skip to content

ui: submit form with false boolean params#5224

Merged
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-ui-form-boolean-params
Jul 27, 2021
Merged

ui: submit form with false boolean params#5224
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-ui-form-boolean-params

Conversation

@shwstppr
Copy link
Contributor

Description

Skip only empty strings while submitting UI form.
Fixes #5223

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Skip only empty strings while submitting UI form.
Fixes apache#5223

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5224 (SL-JID-407)

@davidjumani davidjumani requested a review from utchoang July 26, 2021 09:30
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadvr yadvr added this to the 4.15.2.0 milestone Jul 27, 2021
@yadvr yadvr merged commit 6540d99 into apache:4.15 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants